Fascinated/release-action
1
0
Fork 0
Code Issues Pull Requests 1 Actions Wiki Activity

Merge pull request 'fix: use filepath for attachment name to handle naming when running on windows' (#1) from myrqs/release-action:fix-paths into main

Browse Source 
Reviewed-on: https://gitea.com/actions/release-action/pulls/1
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
Lunny Xiao 2023-05-04 18:19:55 +08:00
commit 420984e082
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
main.go
View File

@ -5,7 +5,6 @@ import (
"fmt"
"net/http"
"os"
"path"
"path/filepath"
"strconv"
"strings"
@ -153,7 +152,7 @@ func uploadFiles(ctx *gha.GitHubContext, c *gitea.Client, owner, repo string, re
}
for _, attachment := range attachments {
if attachment.Name == path.Base(file) {
if attachment.Name == filepath.Base(file) {
if _, err := c.DeleteReleaseAttachment(owner, repo, releaseID, attachment.ID); err != nil {
f.Close()
return fmt.Errorf("failed to delete release attachment %s: %w", file, err)
@ -163,7 +162,7 @@ func uploadFiles(ctx *gha.GitHubContext, c *gitea.Client, owner, repo string, re
}
}
if _, _, err = c.CreateReleaseAttachment(owner, repo, releaseID, f, path.Base(file)); err != nil {
if _, _, err = c.CreateReleaseAttachment(owner, repo, releaseID, f, filepath.Base(file)); err != nil {
f.Close()
return fmt.Errorf("failed to upload release attachment %s: %w", file, err)
}