Fascinated/scoresaber-reloadedv3
Archived
1
1
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Activity

use new stat for ranked and total play count change
Some checks failed
Deploy Backend / docker (ubuntu-latest) (push) Failing after 31s
Details
Deploy Website / docker (ubuntu-latest) (push) Failing after 33s
Details

Browse Source
This commit is contained in:
Lee
2024-10-20 19:49:10 +01:00
parent bded9969fe
commit 06a13bedc8
4 changed files with 28 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
projects/website/src/common/player-utils.ts
View File

@ -7,7 +7,7 @@ import { PlayerHistory } from "@ssr/common/player/player-history";
* @param history the history to get the value from
* @param field the field to get
*/
export function getValueFromHistory(history: PlayerHistory, field: string): number | null {
export function getValueFromHistory(history: PlayerHistory, field: string): number | undefined {
const keys = field.split(".");
/* eslint-disable @typescript-eslint/no-explicit-any */
let value: any = history;
@ -17,10 +17,10 @@ export function getValueFromHistory(history: PlayerHistory, field: string): numb
if (value && key in value) {
value = value[key];
} else {
return null; // Return null if the key doesn't exist
return undefined; // Return null if the key doesn't exist
}
}
// Ensure we return a number or null
return typeof value === "number" ? value : null;
return typeof value === "number" ? value : undefined;
}

12
projects/website/src/components/player/player-stats.tsx
View File

@ -22,14 +22,13 @@ const playerStats: Stat[] = [
name: "Ranked Play Count",
color: "bg-pp",
create: (player: ScoreSaberPlayer) => {
const history = getPlayerHistoryToday(player);
const rankedScores = history.scores?.rankedScores;
const rankedScoresChange = player.statisticChange?.daily.scores?.totalRankedScores;
return {
value: (
<>
{formatNumberWithCommas(player.statistics.rankedPlayCount)}{" "}
<DailyChange type={PlayerStat.RankedPlayCount} change={rankedScores} />
<DailyChange type={PlayerStat.RankedPlayCount} change={rankedScoresChange} />
</>
),
};
@ -56,16 +55,13 @@ const playerStats: Stat[] = [
{
name: "Total Play Count",
create: (player: ScoreSaberPlayer) => {
const history = getPlayerHistoryToday(player);
const rankedScores = history.scores?.rankedScores;
const unrankedScores = history.scores?.unrankedScores;
const totalChange = (rankedScores ?? 0) + (unrankedScores ?? 0);
const scoresChange = player.statisticChange?.daily.scores;
return {
value: (
<>
{formatNumberWithCommas(player.statistics.totalPlayCount)}{" "}
<DailyChange type={PlayerStat.TotalPlayCount} change={totalChange} />
<DailyChange type={PlayerStat.TotalPlayCount} change={scoresChange?.totalScores} />
</>
),
};