From c7dd4709d9a5eb5925fbcf20210673db5d3ff341 Mon Sep 17 00:00:00 2001
From: Liam <liam@fascinated.cc>
Date: Fri, 27 Oct 2023 23:00:54 +0100
Subject: [PATCH] add aria-labels

---
 src/components/Avatar.tsx |  1 -
 src/components/Navbar.tsx | 15 +++++++++++++--
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/src/components/Avatar.tsx b/src/components/Avatar.tsx
index 38f777c..95ba2bd 100644
--- a/src/components/Avatar.tsx
+++ b/src/components/Avatar.tsx
@@ -22,7 +22,6 @@ export default function Avatar({
         src={url}
         width={size}
         height={size}
-        priority
       />
     </>
   );
diff --git a/src/components/Navbar.tsx b/src/components/Navbar.tsx
index 3e8649b..9a50cc5 100644
--- a/src/components/Navbar.tsx
+++ b/src/components/Navbar.tsx
@@ -16,13 +16,15 @@ interface ButtonProps {
   text: string;
   icon?: JSX.Element;
   href?: string;
+  ariaLabel: string;
   children?: React.ReactNode;
 }
 
-function NavbarButton({ text, icon, href, children }: ButtonProps) {
+function NavbarButton({ text, icon, href, ariaLabel, children }: ButtonProps) {
   return (
     <div className="group">
       <a
+        aria-label={ariaLabel}
         className="flex h-full w-fit transform-gpu items-center justify-center gap-1 rounded-md p-3 transition-all hover:cursor-pointer hover:bg-blue-500"
         href={href}
       >
@@ -49,6 +51,7 @@ export default function Navbar() {
       <div className="flex h-fit w-full rounded-md bg-gray-800">
         {settingsStore !== undefined && settingsStore.player && (
           <NavbarButton
+            ariaLabel="Your profile"
             text="You"
             icon={
               <Avatar
@@ -61,7 +64,11 @@ export default function Navbar() {
           />
         )}
 
-        <NavbarButton text="Friends" icon={<UserIcon height={20} width={20} />}>
+        <NavbarButton
+          ariaLabel="View your friends"
+          text="Friends"
+          icon={<UserIcon height={20} width={20} />}
+        >
           {settingsStore?.friends.length == 0 ? (
             <p className="text-sm font-bold">No friends, add someone!</p>
           ) : (
@@ -92,11 +99,13 @@ export default function Navbar() {
           />
         </NavbarButton>
         <NavbarButton
+          ariaLabel="View the global ranking"
           text="Ranking"
           icon={<GlobeAltIcon height={20} width={20} />}
           href="/ranking/global/1"
         />
         <NavbarButton
+          ariaLabel="View analytics for Scoresaber"
           text="Analytics"
           icon={<ServerIcon height={20} width={20} />}
           href="/analytics"
@@ -105,11 +114,13 @@ export default function Navbar() {
         <div className="m-auto" />
 
         <NavbarButton
+          ariaLabel="Search for a player"
           text="Search"
           icon={<MagnifyingGlassIcon height={20} width={20} />}
           href="/search"
         />
         <NavbarButton
+          ariaLabel="View your settings"
           text="Settings"
           icon={<CogIcon height={20} width={20} />}
           href="/settings"