fix(ssr): only use 1 network request to fetch map ids

src/app/api/beatsaver/mapdata/route.ts

@@ -19,14 +19,15 @@ export async function GET(request: Request) {
       const map = await BeatsaverAPI.fetchMapByHash(mapHash);
       if (map) {
         maps[mapHash] = map;
+        mapCache.set(mapHash, map);
       }
       if (map && idOnly) {
         maps[mapHash] = { id: map.id };
       }
     }
+  }
 
   return new Response(JSON.stringify(maps), {
     headers: { "content-type": "application/json;charset=UTF-8" },
   });
-  }
 }

src/utils/scoresaber/api.ts

@@ -162,25 +162,29 @@ async function fetchScoresWithBeatsaverData(
     string,
     ScoresaberScoreWithBeatsaverData
   > = {};
-  for (const score of scores) {
+
-    const mapResponse = await fetch(
+  let url = `${
-      `${
     isProduction() ? ssrSettings.siteUrl : "http://localhost:3000"
-      }/api/beatsaver/mapdata?hashes=${score.leaderboard.songHash}&idonly=true`,
+  }/api/beatsaver/mapdata?hashes=`;
-      {
+  for (const score of scores) {
+    url += `${score.leaderboard.songHash},`;
+  }
+  const mapResponse = await fetch(url, {
     next: {
       revalidate: 60 * 60 * 24 * 7, // 1 week
     },
-      },
+  });
-    );
+  const mapJson = await mapResponse.json();
-    const mapData = await mapResponse.json();
+  for (const score of scores) {
-    const mapId = mapData[score.leaderboard.songHash].id;
+    const mapData = mapJson[score.leaderboard.songHash];
-    scoresWithBeatsaverData[score.score.id] = {
+    if (mapData) {
+      scoresWithBeatsaverData[score.leaderboard.songHash] = {
         score: score.score,
         leaderboard: score.leaderboard,
-      mapId: mapId,
+        mapId: mapData.id,
       };
     }
+  }
 
   return {
     scores: scoresWithBeatsaverData,