many many change

pages/api/beatleader/stars.js

@@ -1,6 +1,6 @@
 import fetch from "node-fetch";
 import WebsiteTypes from "../../../src/consts/LeaderboardType";
-import RedisUtils from "../../../src/utils/redisUtils";
+import { getValue, setValue, valueExists } from "../../../src/utils/redisUtils";
 
 const KEY = "BL_MAP_STAR_";
 
@@ -16,9 +16,9 @@ export default async function handler(req, res) {
 	const characteristic = req.query.characteristic;
 
 	const key = `${KEY}${difficulty}-${characteristic}-${mapHash}`;
-	const exists = await RedisUtils.exists(key);
+	const exists = await valueExists(key);
 	if (exists) {
-		const data = await RedisUtils.getValue(key);
+		const data = await getValue(key);
 		res.setHeader("Cache-Status", "hit");
 
 		return res.status(200).json({
@@ -59,7 +59,7 @@ export default async function handler(req, res) {
 			message: "Unknown Map Hash",
 		});
 	}
-	await RedisUtils.setValue(key, starCount);
+	await setValue(key, starCount);
 	console.log(
 		`[Cache]: Cached BL Star Count for hash ${mapHash} in ${
 			Date.now() - before

pages/api/beatsaver/art/[hash].js

@@ -1,6 +1,10 @@
 import fetch from "node-fetch";
 import sharp from "sharp";
-import RedisUtils from "../../../../src/utils/redisUtils";
+import {
+	getValue,
+	setValue,
+	valueExists,
+} from "../../../../src/utils/redisUtils";
 
 const KEY = "BS_MAP_ART_";
 
@@ -14,9 +18,9 @@ export default async function handler(req, res) {
 	const mapHash = req.query.hash.replace("custom_level_", "").toLowerCase();
 	const ext = req.query.ext || "jpg";
 
-	const exists = await RedisUtils.exists(`${KEY}${mapHash}`.replace(" ", ""));
+	const exists = await valueExists(`${KEY}${mapHash}`.replace(" ", ""));
 	if (exists) {
-		const data = await RedisUtils.getValue(`${KEY}${mapHash}`);
+		const data = await getValue(`${KEY}${mapHash}`);
 		const buffer = Buffer.from(data, "base64");
 		res.writeHead(200, {
 			"Content-Type": "image/" + ext,
@@ -39,7 +43,7 @@ export default async function handler(req, res) {
 	buffer = await sharp(buffer).resize(400, 400).toBuffer();
 	const bytes = buffer.toString("base64");
 
-	await RedisUtils.setValue(`${KEY}${mapHash}`.replace(" ", ""), bytes);
+	await setValue(`${KEY}${mapHash}`.replace(" ", ""), bytes);
 	console.log(
 		`[Cache]: Cached BS Song Art for hash ${mapHash} in ${
 			Date.now() - before

pages/api/beatsaver/map.js

@@ -1,9 +1,9 @@
-import Utils from "../../../utils/utils";
+import { getMapData } from "../../../src/helpers/beatSaverHelpers";
 
 export default async function handler(req, res) {
 	const mapHash = req.query.hash;
 
-	const mapData = await Utils.getMapData(mapHash.replace("custom_level_", ""));
+	const mapData = await getMapData(mapHash);
 	if (mapData === undefined) {
 		// Check if a map hash was provided
 		return res.status(404).json({

pages/api/scoresaber/stars.js

@@ -1,6 +1,6 @@
 import fetch from "node-fetch";
 import WebsiteTypes from "../../../src/consts/LeaderboardType";
-import RedisUtils from "../../../src/utils/redisUtils";
+import { getValue, setValue, valueExists } from "../../../src/utils/redisUtils";
 import { diffToScoreSaberDiff } from "../../../src/utils/scoreSaberUtils";
 
 const KEY = "SS_MAP_STAR_";
@@ -17,9 +17,9 @@ export default async function handler(req, res) {
 	const characteristic = req.query.characteristic;
 
 	const key = `${KEY}${difficulty}-${characteristic}-${mapHash}`;
-	const exists = await RedisUtils.exists(key);
+	const exists = await valueExists(key);
 	if (exists) {
-		const data = await RedisUtils.getValue(key);
+		const data = await getValue(key);
 		res.setHeader("Cache-Status", "hit");
 
 		return res.status(200).json({
@@ -55,7 +55,7 @@ export default async function handler(req, res) {
 			message: "Unknown Map Hash",
 		});
 	}
-	await RedisUtils.setValue(key, starCount);
+	await setValue(key, starCount);
 	console.log(
 		`[Cache]: Cached SS Star Count for hash ${mapHash} in ${
 			Date.now() - before

pages/api/steamavatar.js

@@ -1,7 +1,7 @@
 import fetch from "node-fetch";
 import sharp from "sharp";
 import { isValidSteamId } from "../../src/helpers/validateSteamId";
-import RedisUtils from "../../src/utils/redisUtils";
+import { getValue, setValue, valueExists } from "../../src/utils/redisUtils";
 
 const KEY = "STEAM_AVATAR_";
 const ext = "jpg";
@@ -22,9 +22,9 @@ export default async function handler(req, res) {
 		});
 	}
 
-	const exists = await RedisUtils.exists(`${KEY}${steamId}`);
+	const exists = await valueExists(`${KEY}${steamId}`);
 	if (exists) {
-		const data = await RedisUtils.getValue(`${KEY}${steamId}`);
+		const data = await getValue(`${KEY}${steamId}`);
 		const buffer = Buffer.from(data, "base64");
 		res.writeHead(200, {
 			"Content-Type": "image/" + ext,
@@ -49,7 +49,7 @@ export default async function handler(req, res) {
 	buffer = await sharp(buffer).resize(400, 400).toBuffer();
 	const bytes = buffer.toString("base64");
 
-	await RedisUtils.setValue(`${KEY}${steamId}`, bytes);
+	await setValue(`${KEY}${steamId}`, bytes);
 	console.log(
 		`[Cache]: Cached Avatar for id ${steamId} in ${Date.now() - before}ms`
 	);

src/curve/BeatLeaderCurve.js

@@ -1,5 +1,4 @@
-export default class BeatLeaderCurve {
+function curve(acc, stars) {
-	static curve(acc, stars) {
 	var l = 1 - (0.03 * (stars - 3.0)) / 11.0;
 	var a = 0.96 * l;
 	var f = 1.2 - (0.6 * stars) / 14.0;
@@ -7,12 +6,10 @@ export default class BeatLeaderCurve {
 	return Math.pow(Math.log10(l / (l - acc)) / Math.log10(l / (l - a)), f);
 }
 
-	static getPP(acc, stars) {
+export function getBeatLeaderPP(acc, stars) {
 	if (stars === undefined || acc === undefined) {
 		return undefined;
 	}
-		const pp =
+	const pp = curve(acc / 100, stars - 0.5) * (stars + 0.5) * 42;
-			BeatLeaderCurve.curve(acc / 100, stars - 0.5) * (stars + 0.5) * 42;
 	return Number.isNaN(pp) ? undefined : pp;
 }
-}

src/curve/ScoreSaberCurve.js

@@ -1,8 +1,8 @@
 // Yoinked from https://github.com/Shurdoof/pp-calculator/blob/c24b5ca452119339928831d74e6d603fb17fd5ef/src/lib/pp/calculator.ts
 // Thank for for this I have no fucking idea what the maths is doing but it works!
-export default class ScoreSaberCurve {
+
-	static starMultiplier = 42.11;
+const starMultiplier = 42.11;
-	static ppCurve = [
+const ppCurve = [
 	[1, 7],
 	[0.999, 6.24],
 	[0.9975, 5.31],
@@ -37,7 +37,7 @@ export default class ScoreSaberCurve {
 	[0.0, 0.0],
 ];
 
-	static clamp(value, min, max) {
+function clamp(value, min, max) {
 	if (min !== null && value < min) {
 		return min;
 	}
@@ -49,35 +49,31 @@ export default class ScoreSaberCurve {
 	return value;
 }
 
-	static lerp(v0, v1, t) {
+function lerp(v0, v1, t) {
 	return v0 + t * (v1 - v0);
 }
 
-	static calculatePPModifier(c1, c2, acc) {
+function calculatePPModifier(c1, c2, acc) {
 	const distance = (c2[0] - acc) / (c2[0] - c1[0]);
-		return ScoreSaberCurve.lerp(c2[1], c1[1], distance);
+	return lerp(c2[1], c1[1], distance);
 }
 
-	static findPPModifier(acc, curve) {
+function findPPModifier(acc, curve) {
-		acc = ScoreSaberCurve.clamp(acc, 0, 100) / 100;
+	acc = clamp(acc, 0, 100) / 100;
 
 	let prev = curve[1];
 	for (const item of curve) {
 		if (item[0] <= acc) {
-				return ScoreSaberCurve.calculatePPModifier(item, prev, acc);
+			return calculatePPModifier(item, prev, acc);
 		}
 		prev = item;
 	}
 }
 
-	static getPP(acc, stars) {
+export function getScoreSaberPP(acc, stars) {
-		const ppValue = stars * ScoreSaberCurve.starMultiplier;
+	const ppValue = stars * starMultiplier;
-		const modifier = ScoreSaberCurve.findPPModifier(
+	const modifier = findPPModifier(acc, ppCurve);
-			acc,
-			ScoreSaberCurve.ppCurve
-		);
 
 	const finalPP = modifier * ppValue;
 	return Number.isNaN(finalPP) ? undefined : finalPP;
 }
-}

src/helpers/beatSaverHelpers.js

@@ -0,0 +1,42 @@
+import { getValue, setValue, valueExists } from "../utils/redisUtils";
+
+const BEATSAVER_MAP_API =
+	process.env.NEXT_PUBLIC_HTTP_PROXY +
+	"/https://api.beatsaver.com/maps/hash/%s";
+
+const KEY = "BS_MAP_DATA_";
+
+/**
+ * Gets a specified maps data from BeatSaver
+ *
+ * @param {string} hash
+ * @returns The map data
+ */
+export async function getMapData(hash) {
+	const mapHash = hash.replace("custom_level_", "").toLowerCase();
+
+	const key = `${KEY}${mapHash}`;
+	const exists = await valueExists(key);
+	if (exists) {
+		const data = await getValue(key);
+		return JSON.parse(data);
+	}
+
+	const before = Date.now();
+	const data = await fetch(BEATSAVER_MAP_API.replace("%s", mapHash), {
+		headers: {
+			"X-Requested-With": "BeatSaber Overlay",
+		},
+	});
+	if (data.status === 404) {
+		return undefined;
+	}
+	const json = await data.json();
+	await setValue(key, JSON.stringify(json));
+	console.log(
+		`[Cache]: Cached BS Map Data for hash ${mapHash} in ${
+			Date.now() - before
+		}ms`
+	);
+	return json;
+}

src/helpers/validateSteamId.js

@@ -1,5 +1,5 @@
 import { default as LeaderboardType } from "../consts/LeaderboardType";
-import RedisUtils from "../utils/redisUtils";
+import { getValue, setValue, valueExists } from "../utils/redisUtils";
 import Utils from "../utils/utils";
 
 const KEY = "VALID_STEAM_ID_";
@@ -8,7 +8,7 @@ const TO_CHECK = [
 	LeaderboardType.BeatLeader.ApiUrl.PlayerData,
 ];
 
-async function isValidSteamId(steamId) {
+export async function isValidSteamId(steamId) {
 	if (!steamId) {
 		return false;
 	}
@@ -16,9 +16,9 @@ async function isValidSteamId(steamId) {
 		return false;
 	}
 
-	const exists = await RedisUtils.exists(`${KEY}${steamId}`);
+	const exists = await valueExists(`${KEY}${steamId}`);
 	if (exists) {
-		const data = await RedisUtils.getValue(`${KEY}${steamId}`);
+		const data = await getValue(`${KEY}${steamId}`);
 		return Boolean(data);
 	}
 
@@ -32,13 +32,9 @@ async function isValidSteamId(steamId) {
 		}
 	}
 
-	await RedisUtils.setValue(`${KEY}${steamId}`, valid);
+	await setValue(`${KEY}${steamId}`, valid);
 	console.log(
 		`[Cache]: Cached Steam ID for id ${steamId} in ${Date.now() - before}ms`
 	);
 	return valid;
 }
-
-module.exports = {
-	isValidSteamId,
-};

src/utils/redisUtils.js

@@ -8,7 +8,7 @@ const client = new Redis({
 });
 client.connect().catch(() => {});
 
-async function setValue(key, value, expireAt = 86400) {
+export async function setValue(key, value, expireAt = 86400) {
 	if (client.status === "close" || client.status === "end") {
 		await client.connect().catch(() => {});
 	}
@@ -16,7 +16,7 @@ async function setValue(key, value, expireAt = 86400) {
 	await client.set(key, value, "EX", expireAt);
 }
 
-async function getValue(key) {
+export async function getValue(key) {
 	if (client.status === "close" || client.status === "end") {
 		await client.connect().catch(() => {});
 	}
@@ -34,7 +34,7 @@ async function getValue(key) {
 	return maybe;
 }
 
-async function exists(key) {
+export async function valueExists(key) {
 	if (client.status === "close" || client.status === "end") {
 		await client.connect().catch(() => {});
 	}
@@ -51,9 +51,3 @@ async function exists(key) {
 	const maybe = await yes;
 	return maybe == 1 ? true : false;
 }
-
-module.exports = {
-	getValue,
-	setValue,
-	exists,
-};

src/utils/scoreSaberUtils.js

@@ -1,8 +1,4 @@
-function diffToScoreSaberDiff(diff) {
+export function diffToScoreSaberDiff(diff) {
-	console.log(
-		"🚀 ~ file: scoreSaberUtils.js ~ line 2 ~ diffToScoreSaberDiff ~ diff",
-		diff
-	);
 	switch (diff) {
 		case "Easy": {
 			return 1;
@@ -24,7 +20,3 @@ function diffToScoreSaberDiff(diff) {
 		}
 	}
 }
-
-module.exports = {
-	diffToScoreSaberDiff,
-};

src/utils/utils.js

@@ -1,6 +1,6 @@
 import { default as LeaderboardType } from "../consts/LeaderboardType";
-import BeatLeaderCurve from "../curve/BeatLeaderCurve";
+import { getBeatLeaderPP } from "../curve/BeatLeaderCurve";
-import ScoreSaberCurve from "../curve/ScoreSaberCurve";
+import { getScoreSaberPP } from "../curve/ScoreSaberCurve";
 
 export default class Utils {
 	/**
@@ -32,10 +32,10 @@ export default class Utils {
 
 	static calculatePP(stars, acc, type) {
 		if (type === "BeatLeader") {
-			return BeatLeaderCurve.getPP(acc, stars);
+			return getBeatLeaderPP(acc, stars);
 		}
 		if (type === "ScoreSaber") {
-			return ScoreSaberCurve.getPP(acc, stars);
+			return getScoreSaberPP(acc, stars);
 		}
 		return undefined;
 	}

utils/utils.js

@@ -1,36 +0,0 @@
-const mapCache = new Map();
-
-module.exports = {
-	BEATSAVER_MAP_API:
-		process.env.NEXT_PUBLIC_HTTP_PROXY +
-		"/https://api.beatsaver.com/maps/hash/%s",
-
-	/**
-	 * Gets a specified maps data from BeatSaver
-	 *
-	 * @param {string} hash
-	 * @returns The map data
-	 */
-	async getMapData(hash) {
-		hash = this.BEATSAVER_MAP_API.replace("%s", hash);
-		if (mapCache.has(hash)) {
-			// Return from cache
-			return mapCache.get(hash);
-		}
-
-		const data = await fetch(hash, {
-			headers: {
-				origin: "Fascinated Overlay",
-			},
-		});
-		if (data.status === 404) {
-			return undefined;
-		}
-		const json = await data.json();
-		mapCache.set(hash, json);
-		setTimeout(() => {
-			mapCache.delete(hash);
-		}, 60 * 60 * 1000); // 1h
-		return json;
-	},
-};