From b59db2f8c2a7a06df4d71b791a032c67508e92ab Mon Sep 17 00:00:00 2001 From: V Date: Mon, 9 Oct 2023 03:49:33 +0200 Subject: [PATCH] Drop Firefox extension support Despite me already fixing all issues, mozilla is still giving me more trouble. Now they are asking me to provide them with testing credentials for discord. Not only do i not want to give them my account, it also isn't even possible because of how discord's login from new location verification works i am very tired of having to fight mozilla and their stupid guidelines / requests. publishing to amo is a nightmare. as such, official support for the extension is hereby dropped we cannot even distribute the extension ourselves because extensions NEED TO BE SIGNED to install them (unless you use firefox nightly). and guess how you sign? VIA THEIR STUPID STORE Options for firefox users: - use the UserScript - grab extension-firefox.zip from releases and install it on firefox nightly - make your own firefox developer account and manually sign the extension-firefox.zip and pray they sign it for you (they wouldn't sign my unlisted upload of it) - use a chromium browser --- .github/workflows/publish.yml | 7 ------- README.md | 24 +----------------------- package.json | 2 +- scripts/build/buildWeb.mjs | 7 +++++-- 4 files changed, 7 insertions(+), 33 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 9d56e9a9..e3639548 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -42,13 +42,6 @@ jobs: # Chrome cd dist/chromium-unpacked pnpx chrome-webstore-upload-cli@2.1.0 upload --auto-publish || EXIT_CODE=$? - - # Firefox - cd ../firefox-unpacked - npm i -g web-ext@7.4.0 web-ext-submit@7.4.0 - web-ext-submit || EXIT_CODE=$? - - exit $EXIT_CODE env: # Chrome EXTENSION_ID: ${{ secrets.CHROME_EXTENSION_ID }} diff --git a/README.md b/README.md index e848fd25..cd54fcdc 100644 --- a/README.md +++ b/README.md @@ -22,29 +22,7 @@ The cutest Discord client mod ## Installing / Uninstalling -Click the below button to install Vencord to the Discord Desktop app - -[![Download and run the Installer](https://img.shields.io/github/v/release/Vencord/Installer?label=Download%20Vencord%20Installer&style=for-the-badge)](https://github.com/Vencord/Installer#vencord-installer) - -## Installing on Browser - -[![Get it on the Firefox Webstore](https://blog.mozilla.org/addons/files/2015/11/get-the-addon.png)](https://addons.mozilla.org/en-GB/firefox/addon/vencord-web/) [![Get it on the Chrome Webstore](https://storage.googleapis.com/web-dev-uploads/image/WlD8wC6g8khYWPJUsQceQkhXSlv1/UV4C4ybeBTsZt43U4xis.png)](https://chrome.google.com/webstore/detail/vencord-web/cbghhgpcnddeihccjmnadmkaejncjndb) - -Or use the [UserScript](https://raw.githubusercontent.com/Vencord/builds/main/Vencord.user.js) - Please note that the CSS Editor, Themes loaded from remote sources and co. will not work in the UserScript. Use the extension if you need any of those - -
-Alternative Downloads - -## Vencord Desktop - -> **Warning** -> This is an alternative app. It currently doesn't support keybinds and possibly some more features. If you just want to install to the normal Discord Desktop app, scroll up - -As an alternative to the Discord Desktop app, Vencord also has its own standalone Desktop app that is snappier and lighter than Discord's official Desktop app - -[![Download Vencord Desktop](https://img.shields.io/github/v/release/Vencord/Desktop?label=Download%20Vencord%20Desktop&style=for-the-badge)](https://github.com/Vencord/Desktop#vencord-desktop) - -
+Visit https://vencord.dev/download ## Join our Support/Community Server diff --git a/package.json b/package.json index c005800a..176dd1a7 100644 --- a/package.json +++ b/package.json @@ -94,7 +94,7 @@ "build": { "overwriteDest": true }, - "sourceDir": "./dist/extension-v2-unpacked" + "sourceDir": "./dist/firefox-unpacked" }, "engines": { "node": ">=18", diff --git a/scripts/build/buildWeb.mjs b/scripts/build/buildWeb.mjs index 02e4da0c..353f4e06 100644 --- a/scripts/build/buildWeb.mjs +++ b/scripts/build/buildWeb.mjs @@ -198,5 +198,8 @@ await Promise.all([ buildExtension("firefox-unpacked", ["background.js", "content.js", "manifestv2.json", "icon.png"]), ]); -Zip.sync.zip("dist/chromium-unpacked").compress().save("dist/extension.zip"); -console.info("Packed Chromium Extension written to dist/extension.zip"); +Zip.sync.zip("dist/chromium-unpacked").compress().save("dist/extension-chrome.zip"); +console.info("Packed Chromium Extension written to dist/extension-chrome.zip"); + +Zip.sync.zip("dist/firefox-unpacked").compress().save("dist/extension-firefox.zip"); +console.info("Packed Firefox Extension written to dist/extension-firefox.zip");