fix: prevent min/reduce calls always returning a 0 value

This commit is contained in:
Nick Krecklow 2021-06-07 11:59:56 -05:00
parent 0f297b72a8
commit d491b7844a
No known key found for this signature in database
GPG Key ID: 5F149FDE156FFA94

@ -39,7 +39,7 @@ export class RelativeScale {
// https://stackoverflow.com/questions/63705432/maximum-call-stack-size-exceeded-when-using-the-dots-operator/63706516#63706516 // https://stackoverflow.com/questions/63705432/maximum-call-stack-size-exceeded-when-using-the-dots-operator/63706516#63706516
const max = nonNullData.reduce((a, b) => { const max = nonNullData.reduce((a, b) => {
return Math.max(a, b) return Math.max(a, b)
}, 0) }, Number.NEGATIVE_INFINITY)
return RelativeScale.scale( return RelativeScale.scale(
[0, RelativeScale.isFiniteOrZero(max)], [0, RelativeScale.isFiniteOrZero(max)],
@ -70,10 +70,10 @@ export class RelativeScale {
// https://stackoverflow.com/questions/63705432/maximum-call-stack-size-exceeded-when-using-the-dots-operator/63706516#63706516 // https://stackoverflow.com/questions/63705432/maximum-call-stack-size-exceeded-when-using-the-dots-operator/63706516#63706516
const min = nonNullData.reduce((a, b) => { const min = nonNullData.reduce((a, b) => {
return Math.min(a, b) return Math.min(a, b)
}, 0) }, Number.POSITIVE_INFINITY)
const max = nonNullData.reduce((a, b) => { const max = nonNullData.reduce((a, b) => {
return Math.max(a, b) return Math.max(a, b)
}, 0) }, Number.NEGATIVE_INFINITY)
return { return {
min: RelativeScale.isFiniteOrZero(min), min: RelativeScale.isFiniteOrZero(min),