From 05487d15ca4bde83ebfa40b3f351e12bf738dc59 Mon Sep 17 00:00:00 2001 From: Nick Krecklow Date: Thu, 14 May 2020 20:46:08 -0500 Subject: [PATCH] reduce naming inversion to simplify logic reading --- lib/dns.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/dns.js b/lib/dns.js index b96ca16..a0b7332 100644 --- a/lib/dns.js +++ b/lib/dns.js @@ -52,11 +52,12 @@ class DNSResolver { // Test if the error indicates a miss, or if the records returned are empty if ((err && (err.code === 'ENOTFOUND' || err.code === 'ENODATA')) || !records || records.length === 0) { // Compare config.skipSrvTimeout directly since SKIP_SRV_TIMEOUT has an or'd value - const isSkipSrvTimeoutActive = typeof config.skipSrvTimeout !== 'number' || config.skipSrvTimeout > 0 + // isValidSkipSrvTimeout == whether the config has a valid skipSrvTimeout value set + const isValidSkipSrvTimeout = typeof config.skipSrvTimeout === 'number' && config.skipSrvTimeout > 0 // Only activate _skipSrv if the skipSrvTimeout value is either NaN or > 0 // 0 represents a disabled flag - if (!this._isSkipSrv() && !isSkipSrvTimeoutActive) { + if (!this._isSkipSrv() && isValidSkipSrvTimeout) { this._skipSrv() logger.log('warn', 'No SRV records were resolved for %s. Minetrack will skip attempting to resolve %s SRV records for %d minutes.', this._ip, this._ip, SKIP_SRV_TIMEOUT / (60 * 1000))